Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of Contributing to Wiki and added information into Server Pages #102

Closed
wants to merge 3 commits into from

Conversation

vincentmaule
Copy link

Hello Helio Networks,

Below are changes from a high level:

  • Provided more detail on the steps to follow with contributing to Helio Networks through Gitbooks.
  • Provided more detail on some of the servers used by Helio Networks/Helio Host.
    • Added links to each individual server to Monitoring Service.
    • Provide "Realistic Uptime Goal" to servers where applicable.
    • Added Tags to servers where applicable.

Please let me know if anything needs to be changed.

Kind Regards,
Vince

Copy link
Contributor

@Kryd0s Kryd0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VPS that is being monitored is actually on Annie right now, not Sparkie.

@vincentmaule vincentmaule requested a review from Kryd0s May 12, 2024 21:57
@vincentmaule
Copy link
Author

Hello Kryd0s,

Thank you for pointing this out!

The VPS that is being monitored is actually on Annie right now, not Sparkie.

I have made the changes to reflect this comment.
It was a good thing to as I did find two links using www within them & have modified those.

Please let me know if there are any other changes I need to make.
Kind Regards,
Vince

Copy link
Contributor

@Kryd0s Kryd0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the   on the contributing page.

@vincentmaule
Copy link
Author

Thanks for finding that;

  • I have removed the space/  as mentioned in the contributing page.
  • I have modified an & -> and as that is a force of habit for personal documentation.
  • Re-reviewed all other files that could be a cause for holding this PR.

Please let me know if there are any other changes I need to make.
Kind Regards,
Vince

@vincentmaule vincentmaule requested a review from Kryd0s May 12, 2024 22:59
Copy link
Contributor

@Kryd0s Kryd0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the title from "Table of Contents" to "Table of contents" with a lowercase c? Here is a guide for capitalization of titles https://www.grammarly.com/blog/capitalization-in-the-titles/ The rules are fairly complicated, I agree, but nouns should definitely remain capitalized.

@vincentmaule
Copy link
Author

Hello Kryd0s & HelioNetworks,

It seems as though this Pull Request runs in direct conflict with the contribution guidelines as listed in the Code Style (Missed this before as this must be page that will only be shown through Git Repo & not live in the Wiki) Page.

As such, I will Close with Comment since this Pull Request does not meet the spirit of the requirements.

Kind Regards,
Vince

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants