New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment replies #282
Add comment replies #282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
============================================
- Coverage 73.88% 73.80% -0.09%
- Complexity 113 119 +6
============================================
Files 44 45 +1
Lines 494 500 +6
============================================
+ Hits 365 369 +4
- Misses 129 131 +2
Continue to review full report at Codecov.
|
Запилишь демку? |
@if ($comment->isReply()) | ||
<span class="small">- {{ __('comment.reply_to_comment') }} <a href="{{ getCommentLink($comment->parent) }}">#</a></span> | ||
@endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
кажется тут два раза small идет друг за другом, там вообще читаемый текст остался?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,24 @@ | |||
<div class="modal fade" id="reply-modal-{{ $comment->id }}" tabindex="-1" role="dialog"> | |||
<div class="modal-dialog" role="document"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в последней версии убрали role
twbs/bootstrap#30687
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в последней версии убрали role
twbs/bootstrap#30687
тогда в edit модалке это тоже надо фиксить
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ну и тут получается тоже не то убрано
|
По визуалу, предлагаю время комментария унести на край вправо, |
Не забудь обновить демку, можно в хероку выбрать автодеплой твоей ветки, чтобы актуальные изменения были видны. |
Я знаю, спасибо, она как раз обновляется сейчас. |
Предлагаю убрать внешнюю рамку в комментарии или добавить фон, но надо посмотреть, чтобы не сливалось с формой ввода.. |
move comment validation to request
<div class="modal fade" id="comment-modal-{{ $comment->id }}" tabindex="-1"> | ||
<div class="modal-dialog" role="document"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я писал про role="document"
, а не dialog
не то удалили :)
@@ -0,0 +1,24 @@ | |||
<div class="modal fade" id="reply-modal-{{ $comment->id }}" tabindex="-1" role="dialog"> | |||
<div class="modal-dialog" role="document"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ну и тут получается тоже не то убрано
Добавил ответы на комментарии и слегка отрефакторил контроллер, вынеся валидацию в реквест.