New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select2 v4.0.9 support #16
Conversation
Updated info |
Hi @aTei , thank you for this contribution. I think that if I merge this PR the gem won't work for select2 v4.0.5? Any ideas? |
The only option I see is to make it the same way as was done separation between 2, 3 & 4 |
Let me think a bit |
Yea, could you go with this solution for now and add one test case for version v4.0.10 in a separate test file ( Note that you will need separate fixture html for version |
Maybe omit |
Any chance this can make it as a released version? |
@MatthewKennedy, this PR cannot be merged now because it breaks support for previous versions of select2 (v4.0.5 for example) |
Hi @aTei , thank you for this contribution. I decided to test select2 version |
Not working for prev v4.0.* versions
https://github.com/select2/select2/releases/tag/4.0.9
Related commit select2/select2#5582