Skip to content

dev-cmd: add dispatch-build-bottle command #7925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2020
Merged

dev-cmd: add dispatch-build-bottle command #7925

merged 1 commit into from
Oct 12, 2020
+110 −0

Conversation

dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented Jul 6, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Companion command for new workflow at homebrew-core, introduced in: Homebrew/homebrew-core#57558

Name of this command should be changed, cause there is one in homebrew-linux-dev, named the same. I just didn't think of a better one yet.

Sorry, something went wrong.

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Jul 6, 2020
@Homebrew Homebrew deleted a comment from request-info bot Jul 6, 2020
@dawidd6 dawidd6 removed the needs response Needs a response from the issue/PR author label Jul 6, 2020
@dawidd6 dawidd6 marked this pull request as draft July 6, 2020 20:22
@MikeMcQuaid
Copy link
Member

I'm wondering if https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/ could replace (or at least "act consistently to") this?

@dawidd6 dawidd6 force-pushed the dev-cmd-bottle branch 4 times, most recently from 196ecfb to 4de9036 Compare July 9, 2020 10:54
@dawidd6 dawidd6 changed the title dev-cmd: add request-bottle command dev-cmd: add dispatch-build-bottle command Jul 29, 2020
@dawidd6 dawidd6 force-pushed the dev-cmd-bottle branch 2 times, most recently from 61ce484 to be1b0e3 Compare July 29, 2020 10:58
@dawidd6 dawidd6 marked this pull request as ready for review July 29, 2020 10:59
@stale
Copy link

stale bot commented Aug 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Aug 22, 2020
@dawidd6 dawidd6 added the in progress Maintainers are working on this label Aug 22, 2020
@stale stale bot removed the stale No recent activity label Aug 22, 2020
@dawidd6 dawidd6 requested a review from MikeMcQuaid October 8, 2020 10:24
MikeMcQuaid
MikeMcQuaid approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but not a blocker, can be addressed after merge 👍🏻

MikeMcQuaid
MikeMcQuaid approved these changes Oct 8, 2020
View reviewed changes
@dawidd6
dev-cmd: add dispatch-build-bottle command

Verified

This commit was signed with the committer’s verified signature.
dawidd6 Dawid Dziurla
GPG key ID: 7B6D8368172E9B0B
Verified
Learn about vigilant mode
3095fbc
MikeMcQuaid
MikeMcQuaid approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (assuming it all works as expected)!

Library/Homebrew/dev-cmd/dispatch-build-bottle.rb

raise FormulaUnspecifiedError if args.named.empty?

odie "Must specify --macos option" unless args.macos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need to be in this PR but it would be useful probably to have a way of triggering this for all macOS versions (if you want to build new bottles for all three versions without a revision PR job).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to do this in the future if there is a demand for that. It will require workflow changes, as we will have to construct a build matrix first, to build on multiple OSes and also create a second job which downloads bottles artifact and then does the upload to Bintray.

Now that I'm thinking about it, I might split the uploading/publishing steps into a second job now (soon), as it can become clearer for people what is going on in the workflow file and it will be easier to maintain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to do this in the future if there is a demand for that.

There is, saw @fxcoudert asking for it the other day 😂.

👍🏻 on everything else, nice work again 👏🏻

@dawidd6 dawidd6 merged commit ffe7f2a into Homebrew:master Oct 12, 2020
@dawidd6 dawidd6 deleted the dev-cmd-bottle branch October 12, 2020 08:33
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid

Assignees
No one assigned
Labels
in progress Maintainers are working on this outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidd6 @MikeMcQuaid @BrewTestBot