Skip to content

Fix cleanup ruby logic #8306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Aug 11, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #7743

Align the logic in cleanup_portable_ruby with that in ruby.sh.

Sorry, something went wrong.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far but, stepping back, I wonder if this could all be a Bash function we could shell out to run instead? Shelling out to brew shellenv only takes 0.3s on my system and if we called ruby.sh directly we could perhaps be even faster.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this so far, @maxim-belkin!

@maxim-belkin maxim-belkin marked this pull request as draft August 21, 2020 23:48
@maxim-belkin maxim-belkin force-pushed the fix-cleanup-ruby-logic branch 2 times, most recently from 65ed5ab to 2312998 Compare August 24, 2020 15:20
@MikeMcQuaid MikeMcQuaid force-pushed the fix-cleanup-ruby-logic branch 2 times, most recently from 524f700 to 2ef8032 Compare September 2, 2020 16:22
@maxim-belkin
Copy link
Contributor Author

Thanks, @MikeMcQuaid. Why did you add .3 to HOMEBREW_REQUIRED_RUBY_VERSION?

@MikeMcQuaid
Copy link
Member

@maxim-belkin That's the required system version on macOS (that we're checking in brew doctor) and it's easier to discard the parts we don't need for supported versions.

@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review September 3, 2020 08:31
@MikeMcQuaid MikeMcQuaid force-pushed the fix-cleanup-ruby-logic branch from 53c93ea to 296e99d Compare September 3, 2020 08:31
Align the logic in `cleanup_portable_ruby` with that in `ruby.sh`.

Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@MikeMcQuaid MikeMcQuaid force-pushed the fix-cleanup-ruby-logic branch from 296e99d to a6d2989 Compare September 3, 2020 08:43
@MikeMcQuaid
Copy link
Member

Let's see how this goes, thanks for your work on this @maxim-belkin!

@MikeMcQuaid MikeMcQuaid merged commit 0aed6e9 into Homebrew:master Sep 3, 2020
@maxim-belkin maxim-belkin deleted the fix-cleanup-ruby-logic branch September 4, 2020 17:59
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew cleanup cleans vendored portable-ruby prerequisite, next brew command verbosely resolves it again
4 participants