bintray: don't output raw JSON

[dawidd6]

Current situation:
https://github.com/Homebrew/homebrew-core/runs/1018446727?check_suite_focus=true#step:5:46

Situation after this PR:
https://github.com/dawidd6/homebrew-tap/runs/1018549880#step:5:44

With this PR, we no longer see the JSON received from Bintray.
It's redundant to see it, it lacks final newline and messes the whole output a bit.
We already parse and check this JSON, no need to output it too.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[reitermarkus]

We have curl_output which does exactly that.

[dawidd6]

def curl_output calls curl command via system_command without exclamation mark, while def curl does. This is essential, we need it to throw an exception if something goes wrong.

[reitermarkus]

Ah, okay. However, I'm not quite sure it makes sense that show_output depends on verbose?, since this also controls passing the --fail flag, so we might get different behaviour depending on the verbosity.

[MikeMcQuaid]

Ah, okay. However, I'm not quite sure it makes sense that show_output depends on verbose?, since this also controls passing the --fail flag, so we might get different behaviour depending on the verbosity.

Agreed 👍🏻

[dawidd6]

Rebased on latest master. Any ideas on how to resolve this verbose? concern?

[MikeMcQuaid]

@dawidd6 I'm not sure, @reitermarkus?

[reitermarkus]

I'd say just remove show_output: verbose? altogether.

[dawidd6]

@jonchang what do you think?

[jonchang]

Ah, okay. However, I'm not quite sure it makes sense that show_output depends on verbose?, since this also controls passing the --fail flag, so we might get different behaviour depending on the verbosity.

At some point we're going to have to clean up how we use curl in Homebrew since the --fail stuff has bit us before.

I'd say just remove show_output: verbose? altogether.

I think this is an acceptable solution for now.