Skip to content

workflows: don't test paths on master. #8472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Conversation

MikeMcQuaid
Copy link
Member

This avoids weirdness like the merged PR commits being pushed to scheduled opened PRs after merging.

It also avoids wasting resources.


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sorry, something went wrong.

@dawidd6
Copy link
Contributor

dawidd6 commented Aug 24, 2020

Maybe just:

branches-ignore:
  - master

would be sufficient?

This avoids weirdness like the merged PR commits being pushed to scheduled opened PRs after merging.

It also avoids wasting resources.
@MikeMcQuaid
Copy link
Member Author

@dawidd6 Thanks, pushed.

@MikeMcQuaid MikeMcQuaid force-pushed the workflows-not-master branch from 0f37f76 to c6a5ea5 Compare August 26, 2020 13:02
@MikeMcQuaid MikeMcQuaid force-pushed the workflows-not-master branch from 3ce27fd to 9ae0208 Compare August 26, 2020 13:25
@MikeMcQuaid MikeMcQuaid merged commit 7f4623a into master Aug 26, 2020
@MikeMcQuaid MikeMcQuaid deleted the workflows-not-master branch August 26, 2020 14:21
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 15, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants