Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unvendored RubyGems #8511

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Fix unvendored RubyGems #8511

merged 1 commit into from
Aug 27, 2020

Conversation

MikeMcQuaid
Copy link
Member

  • Avoid caching RubyGems in GitHub Actions tests.yml to catch this in
    future.
  • Run brew doctor in GitHub Actions tests.yml after installing
    RubyGems to catch this in future.
  • Ignore relevant RubyGems (and fix outdated comments)
  • Never auto-require RubyGems that aren't vendored.
  • Update bundler/setup.rb.

Alternate approach to #8508
Fixes #8503 (comment)


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
- Avoid caching RubyGems in GitHub Actions `tests.yml` to catch this in
  future.
- Run `brew doctor` in GitHub Actions `tests.yml` after installing
  RubyGems to catch this in future.
- Ignore relevant RubyGems (and fix outdated comments)
- Never auto-`require` RubyGems that aren't vendored.
- Update `bundler/setup.rb`.
@MikeMcQuaid MikeMcQuaid merged commit 435ff54 into Homebrew:master Aug 27, 2020
@MikeMcQuaid MikeMcQuaid deleted the fix-gems branch August 27, 2020 13:27
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 15, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants