enable patchelf.rb writing for devs.

[rmNULL]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

cc @sjackman @woodruffw

[sjackman]

Suggested change

	ENV["HOMEBREW_PATCHELF_RB_WRITE"].present? || ENV["HOMEBREW_DEVELOPER"].present? &&
	!(ENV["CI"].present? || ENV["NO_HOMEBREW_PATCHELF_RB_WRITE"].present?)
	ENV["HOMEBREW_PATCHELF_RB_WRITE"].present?
	|| ENV["HOMEBREW_DEVELOPER"].present?
	&& !ENV["CI"].present?
	&& !ENV["HOMEBREW_NO_PATCHELF_RB_WRITE"].present?)

[rmNULL]

i'll separate the &s.
ruby has problems parsing operators on next line,
even i prefer
A
&& b
|| c

over
A &&
b ||
c

P.S: using backslash is awkward -_-

[MikeMcQuaid]

Suggested change

	ENV["HOMEBREW_PATCHELF_RB_WRITE"].present? ||
	ENV["HOMEBREW_DEVELOPER"].present? &&
	(ENV["HOMEBREW_PATCHELF_RB_WRITE"].present? ||
	ENV["HOMEBREW_DEVELOPER"].present?) &&

[sjackman]

Suggested change

	(ENV["HOMEBREW_PATCHELF_RB_WRITE"].present? ||
	ENV["HOMEBREW_DEVELOPER"].present?) &&
	!ENV["CI"].present? &&
	!ENV["NO_HOMEBREW_PATCHELF_RB_WRITE"].present?
	!ENV["HOMEBREW_NO_PATCHELF_RB_WRITE"].present? &&
	(ENV["HOMEBREW_PATCHELF_RB_WRITE"].present? ||
	(!ENV["CI"].present? && ENV["HOMEBREW_DEVELOPER"].present?))

if HOMEBREW_NO_PATCHELF_RB_WRITE then off
if HOMEBREW_PATCHELF_RB_WRITE then on
if CI then off
if HOMEBREW_DEVELOPER then on
otherwise off