Skip to content

Split check_style_impl into run_rubocop and run_shellcheck. #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Aug 30, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Also add JSON output for ShellCheck so we can output violations as annotations on GitHub Actions in the future.

Sorry, something went wrong.

@MikeMcQuaid
Copy link
Member

Thanks @reitermarkus!

@reitermarkus reitermarkus merged commit f8c3a1b into Homebrew:master Aug 31, 2020
@reitermarkus reitermarkus deleted the shellcheck-json branch August 31, 2020 18:43
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants