Remove need for separate .rubocop_cask.yml.

[reitermarkus]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Cask cops only run on cask "…" do blocks, so we can just enable them globally.

[MikeMcQuaid]

Nice cleanup!

[claui]

This breaks brew audit Formula/myformula.rb if you’re in a working copy of a git cloned tap.

I don’t speak RuboCop so I tried several shots in the dark, i. e. removing the Taps/*/*/ part in all the Exclude directives. That didn’t work though.

This variant of brew audit has worked for years and I’d be super happy to get this working again. @reitermarkus Can you help?

[reitermarkus]

@claui what exactly is not working anymore?

Maybe try changing the excludes from Taps/**/Formula/*.rb to just **/Formula/*.rb.

[claui]

what exactly is not working anymore?

@reitermarkus The audit now reports findings that don’t really make sense for formulae. For example:

$ brew audit Formula/node.rb
node:
  * C: 1: col 1: Missing top-level class documentation comment.
  * C: 1: col 1: Missing frozen string literal comment.
  * C: 32: col 3: Assignment Branch Condition size for install is too high. [<3, 33, 2> 33.2/17]
  * C: 32: col 3: Method has too many lines. [14/10]
  * C: 53: col 13: Align the arguments of a method call if they span more than one line.
  * C: 65: col 3: Assignment Branch Condition size for post_install is too high. [<2, 25, 1> 25.1/17]
  * C: 65: col 3: Method has too many lines. [12/10]
  * Formula has other versions so create an alias named node@14.
Error: 8 problems in 1 formula detected

[reitermarkus]

@claui, remove the / in front of the paths.

[claui]

@reitermarkus I’ve already tried that but it wouldn’t work because Rubocop interprets it relative to the YAML file’s location.

[MikeMcQuaid]

@reitermarkus I think this has made brew style --fix --display-cop-names homebrew/bundle now check the vendor directory in that tap.

[reitermarkus]

@MikeMcQuaid when does it create a vendor directory? bundle install doesn't create it for me locally.

[MikeMcQuaid]

@reitermarkus I've got a global BUNDLE_PATH: "vendor/ruby" set which may be related. Ignoring vendor would be nice in general, I think, although arguably there should be per-repo configuration there?

[reitermarkus]

I actually think I removed it because vendor/**/* is ignored by default. Maybe just adding **/vendor/**/* will fix it.