Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: remove test for livecheck_formulae #8544

Merged
merged 1 commit into from
Aug 31, 2020
Merged

livecheck: remove test for livecheck_formulae #8544

merged 1 commit into from
Aug 31, 2020

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR removes the network test for livecheck_formulae as it was failing sometimes. We will be adding network-related tests for livecheck later on in another PR after finding out why CI fails for GitHub URLs and now for other URLs too.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
nandahkrishna Nanda H Krishna
@MikeMcQuaid
Copy link
Member

Thanks for the quick fix @nandahkrishna!

@nandahkrishna nandahkrishna deleted the remove-livecheck-test branch August 31, 2020 11:37
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants