Skip to content

Output GitHub Actions annotations for brew style. #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2020
Merged

Output GitHub Actions annotations for brew style. #8564

merged 2 commits into from
Sep 2, 2020
+146 −30

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 1, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sorry, something went wrong.

@reitermarkus reitermarkus force-pushed the rubocop-json branch 7 times, most recently from a668dea to 422dc0e Compare September 1, 2020 23:41
MikeMcQuaid
MikeMcQuaid approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Some suggestions but nothing blocking.

Library/Homebrew/utils/github/actions.rb
@@ -0,0 +1,38 @@
# frozen_string_literal: true

module GitHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this should be in a Utils module too based on the name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but the existing GitHub module is not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider moving those files around?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which ones? Move GitHub out of utils?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth moving at this moment. I think eventually all modules should follow the file structure and also all of them should be contained in the Homebrew namespace.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@reitermarkus
Output GitHub Actions annotations for brew style.
ebd4ce4
@reitermarkus
Add test for GitHub::Actions::Annotation.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4d1fa19
@reitermarkus reitermarkus merged commit 172f55f into Homebrew:master Sep 2, 2020
@reitermarkus reitermarkus deleted the rubocop-json branch September 2, 2020 16:11
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @MikeMcQuaid @BrewTestBot