-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: migrate to GitHub Container Registry. #8569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker.pkg.github.com/OWNER/REPOSITORY/IMAGE_NAME
ghcr.io/OWNER/IMAGE_NAME
Notice that it's not ghcr.io/OWNER/REPOSITORY/IMAGE_NAME
but instead ghcr.io/OWNER/IMAGE_NAME
, so ghcr.io/homebrew/brew/…
needs to change to ghcr.io/homebrew/…
throughout.
It also needs a new PAT as it can't use GITHUB_TOKEN:
|
e2154ef
to
73d2186
Compare
Done! |
This seems a better fit for us (unauthenticated anonymous access) than GitHub Packages Docker registry was. Followed steps on: https://docs.github.com/en/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images
73d2186
to
8d07f4f
Compare
Done! |
Let's see how this goes 🤞🏻 |
Working (finally): https://github.com/Homebrew/brew/runs/1066866856#step:24:1 |
This seems a better fit for us (unauthenticated anonymous access) than GitHub Packages Docker registry was.
Followed steps on https://docs.github.com/en/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images
brew style
with your changes locally?brew tests
with your changes locally?