Skip to content

Do not suggest use of deprecated brew cask reinstall #8599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Do not suggest use of deprecated brew cask reinstall #8599

merged 1 commit into from
Sep 4, 2020

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Sep 4, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I got a warning Warning: Calling brew cask reinstall is deprecated! Use brew reinstall instead. after copy-pasting a suggestion from brew cask install, so I corrected the suggestion. Let me know if I should write tests for this!

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
dawidd6 Dawid Dziurla
@MikeMcQuaid MikeMcQuaid merged commit 537a93c into Homebrew:master Sep 4, 2020
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @Luthaf!

@Luthaf Luthaf deleted the cask-reinstall branch September 4, 2020 14:08
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants