Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github: add create_bump_pr #8603

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This adds an open_pr method that will be useful for brew bump-cask-pr (#7986)

I currently have open_pr in dev-cmd/bump-formula-pr.rb to keep the diff clean — I'll probably move it to utils/github.rb once this is approved

Sorry, something went wrong.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@SeekingMeaning SeekingMeaning force-pushed the open_pr branch 2 times, most recently from 65618fc to 714a508 Compare September 4, 2020 19:24
@SeekingMeaning SeekingMeaning changed the title bump-formula-pr: create open_pr method utils/github: add create_bump_pr Sep 4, 2020
@SeekingMeaning
Copy link
Contributor Author

SeekingMeaning commented Sep 4, 2020

@SeekingMeaning SeekingMeaning merged commit 4a32547 into Homebrew:master Sep 4, 2020
@SeekingMeaning SeekingMeaning deleted the open_pr branch September 4, 2020 21:31
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants