Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_config.rb: refactor code into worker functions #8608

Merged

Conversation

maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Sep 4, 2020

This PR breaks down dump_verbose_config function into "worker" functions that display information for specific categories:

  • core_tap_config for Core tap info
  • homebrew_config for Homebrew/brew info
  • homebrew_env_config for environment-related information
  • host_software_config for Host software

Also, I factored out code related to Clang into a new describe_clang function, so that we can do:

f.puts "Clang: #{describe_clang}"

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sorry, something went wrong.

Break down `dump_verbose_config` function into "worker" functions that
display information for specific categories:

- `core_tap_config` for Core tap info
- `homebrew_config` for Homebrew/brew info
- `homebrew_env_config` for environment-related information
- `host_software_config` for Host software

Also, factor out code related to Clang into `describe_clang` function,
so that we can do:

```
f.puts "Clang: #{describe_clang}"
```
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

@maxim-belkin
Copy link
Contributor Author

Nice cleanup.

Thank you! :)

@maxim-belkin maxim-belkin merged commit 1792cdf into Homebrew:master Sep 7, 2020
@maxim-belkin maxim-belkin deleted the system_config_code_reorg branch September 7, 2020 17:39
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants