Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: expedite check for missing mirror argument #8610

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Previously, the check for --mirror would happen after the formula was updated with the new url and sha256, which would erase the mirror stanza if no --mirror was specified.

This PR moves this check to happen earlier so that no changes are made to the formula if --mirror is missing

Sorry, something went wrong.

@SeekingMeaning SeekingMeaning merged commit bf7fc0b into Homebrew:master Sep 7, 2020
@SeekingMeaning SeekingMeaning deleted the bump-formula-pr/missing-mirror branch September 7, 2020 15:24
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants