Skip to content

utils: add tar #8611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

utils: add tar #8611

merged 1 commit into from
Sep 8, 2020
+90 −13

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Sep 4, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This adds a helper function that checks if a file is a valid tar file

This would be useful for brew bump-cask-pr (#7986)

Sorry, something went wrong.

@SeekingMeaning SeekingMeaning force-pushed the bump-formula-pr/validate_tar_download branch 2 times, most recently from 9e8c6d7 to caa3789 Compare September 7, 2020 18:20
@SeekingMeaning SeekingMeaning changed the title bump-formula-pr: add validate_tar_download utils: add tar Sep 7, 2020
MikeMcQuaid
MikeMcQuaid approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 to merging if it'll be immediately used in another command. Tests would be nice if you can be bothered but don't need to block this.

@SeekingMeaning SeekingMeaning force-pushed the bump-formula-pr/validate_tar_download branch 3 times, most recently from 2fae90d to 4226363 Compare September 7, 2020 19:28
@SeekingMeaning
utils: add tar

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
15af718 
Includes `validate_file` method to be used by `bump-formula-pr`
@SeekingMeaning SeekingMeaning force-pushed the bump-formula-pr/validate_tar_download branch from 4226363 to 15af718 Compare September 8, 2020 14:08
@SeekingMeaning
Copy link
Contributor Author

Added test for available?

@SeekingMeaning SeekingMeaning merged commit b94f04b into Homebrew:master Sep 8, 2020
@SeekingMeaning SeekingMeaning deleted the bump-formula-pr/validate_tar_download branch September 8, 2020 14:57
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SeekingMeaning @MikeMcQuaid @BrewTestBot