Skip to content

Ignore URLs protected by CloudFlare when auditing. #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 5, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Otherwise audit will fail on URLs protected by CloudFlare, despite them being available in a browser.

CI failure here: Homebrew/homebrew-cask#88655

Sorry, something went wrong.

Co-authored-by: Seeker <meaningseeking@protonmail.com>
@reitermarkus reitermarkus merged commit 9e0a26a into Homebrew:master Sep 5, 2020
@reitermarkus reitermarkus deleted the audit-cloudflare-protection branch September 5, 2020 22:26
@MikeMcQuaid
Copy link
Member

Nice catch 👏🏻

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants