Skip to content

Remove trailing slash from SPDX license exception URL #8620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Remove trailing slash from SPDX license exception URL #8620

merged 1 commit into from
Sep 5, 2020

Conversation

nwhetsell
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The URL for the SPDX license exception webpage is currently https://spdx.org/licenses/exceptions-index.html/:

#{Formatter.url("https://spdx.org/licenses/exceptions-index.html/")}

Because of the trailing slash, the SPDX website attempts to load—

https://spdx.org/licenses/exceptions-index.html/index.html

—which results in a 404 error. This pull request removes the trailing slash.

Sorry, something went wrong.

@Rylan12
Copy link
Member

Rylan12 commented Sep 5, 2020

Good catch, @nwhetsell! Looks good to me. CI is failing but it looks like it's unrelated. I've triggered the CI to run again and we can see if there's still an issue.

@Rylan12 Rylan12 merged commit 7bd2f51 into Homebrew:master Sep 5, 2020
@Rylan12
Copy link
Member

Rylan12 commented Sep 5, 2020

Thanks, @nwhetsell!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants