shared_audits: ensure GitLab API response is valid

[dtrodrigues]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

The GitLab API returns an HTTP 403 and a body of
{"message":"403 Forbidden"}
if a release doesn't exist, eg https://gitlab.com/api/v4/projects/gitlab-org%2Fgitlab-runner/releases/does-not-exist. This causes the current audit logic to fail when trying to get release_date. The change will ensure there's a release_date in the response before continuing.

For a more robust solution, the HTTP response code should be considered for GitLab API calls prior to working with the data.

Resolves audit exception in Homebrew/homebrew-core#60669

[reitermarkus]

If the API still returns a JSON body on error why does parse fail?

[reitermarkus]

Maybe pass --fail to curl_output rather than checking the output?

[reitermarkus]

Also the--request GET can be removed since that's the default.

[dtrodrigues]

Date.parse(release["released_at"]) threw an exception because release["released_at"] was nil and Date.parse takes in a string.

I did change to use the --fail flag instead for the curl call.

[reitermarkus]

Date.parse(release["released_at"]) threw an exception

Ah, I thought it was JSON.parse.