Add flowchart for managing ready-to-merge PRs

[claui]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This documentation PR adds a flowchart and a diagram guideline.

Flowchart for managing ready-to-merge PRs

A flowchart can be a helpful addition to a complex decision tree.
Many thanks to @SMillerDev for the idea and initial version of the chart.

New diagram guideline

Looks like this is the first diagram in the Homebrew documentation so it’s a good time for a little guideline, too.
Pinging @Homebrew/tsc but feedback welcome from everyone, of course.

[SMillerDev]

I'd say the stuff about the driver should be a separate pull request. It's useful, but it really distracts from the added diagram.

[claui]

I'd say the stuff about the driver should be a separate pull request.

Makes sense! Removed for now.

[nandahkrishna]

I don't mean to be bikeshedding here, but the "Modify and push" text doesn't have a white background (like "Push the button" and unlike "Yes"), so the "a" in "and" seems a little too close to the line. Is it possible to make the text background white or is it intentionally this way? Disclaimer: I don't know anything about rules for diagrams 😅

[claui]

I don't mean to be bikeshedding here, but the "Modify and push" text doesn't have a white background

@nandahkrishna Fixed, thanks!

And yes, that’s exactly the kind of feedback I meant to solicit ❤️

[Rylan12]

The diagram looks good to me. If you wanted to reduce the complexity a little bit, you could probably combine the "Does it say bottle :unneeded?" and "Rebuild bottles afterwards?" questions into e.g. "Are there bottles that need to be rebuilt?". The benefit here would be to simplify the diagram a little, but I don't think that's necessary.

[reitermarkus]

Are there bottles that need to be rebuilt?

I don't think it's really clear how to answer this question without the explicit “check for bottle :unneeded” step.

[MikeMcQuaid]

Looks good, thanks for this @claui and all the help @SMillerDev and others.

[claui]

Thank you all for the thorough review and helpful feedback @nandahkrishna @Rylan12 @SMillerDev @MikeMcQuaid @reitermarkus!

[Rylan12]

Looks good! One minor thing: the color of the ✅ is a little distorted. It's not unreadable, though, so maybe not worth fixing.

[MikeMcQuaid]

Thanks @claui! Would be good to fix that if possible.