Skip to content

audit: allowlist some formulae homepage cert issues #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Sep 7, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

relates to Homebrew/homebrew-core#60591

Sorry, something went wrong.

@chenrui333 chenrui333 changed the title audit: fix micropython homepage cert issue audit: allowlist some formulae Sep 7, 2020
@chenrui333 chenrui333 changed the title audit: allowlist some formulae audit: allowlist some formulae homepage cert issues Sep 7, 2020

Verified

This commit was signed with the committer’s verified signature.
@chenrui333 chenrui333 force-pushed the include-micropython-homepage-to-cert-error-allow-list branch from f09b905 to 483fcd5 Compare September 7, 2020 00:18
@MikeMcQuaid
Copy link
Member

Do these all work in e.g. Safari?

@chenrui333
Copy link
Member Author

chenrui333 commented Sep 12, 2020

yeah, it works on safari as this:
image

this is the known libssl issue, libressl/portable#595

@chenrui333
Copy link
Member Author

libpqxx also suffered the issue as well (Homebrew/homebrew-core#61385)

@jonchang jonchang merged commit 187b563 into Homebrew:master Sep 21, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants