Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate_disable: refactor and add to info #8635

Merged
merged 1 commit into from
Sep 8, 2020
Merged

deprecate_disable: refactor and add to info #8635

merged 1 commit into from
Sep 8, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Sep 7, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Refactor the deprecate_disable reason logic to a separate module.

This allows code to be used to show deprecation and disable information in brew info.

I will almost always run brew info before installing something, so it would be helpful to see whether the formula I'm about to install is deprecated or disabled.

Before:

$ brew info tj
tj: stable 7.0.0 (bottled)
Line timestamping tool
https://github.com/sgreben/tj
Not installed
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/tj.rb
==> Dependencies
Build: go ✘
==> Analytics
install: 0 (30 days), 1 (90 days), 21 (365 days)
install-on-request: 0 (30 days), 1 (90 days), 21 (365 days)
build-error: 0 (30 days)

After:

$ brew info tj
tj: stable 7.0.0 (bottled)
Line timestamping tool
https://github.com/sgreben/tj
Disabled because it has no license!
Not installed
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/tj.rb
==> Dependencies
Build: go ✘
==> Analytics
install: 0 (30 days), 1 (90 days), 21 (365 days)
install-on-request: 0 (30 days), 1 (90 days), 21 (365 days)
build-error: 0 (30 days)

Sorry, something went wrong.

@Rylan12 Rylan12 merged commit 7d92454 into Homebrew:master Sep 8, 2020
@Rylan12 Rylan12 deleted the deprecate_disable_info branch September 8, 2020 15:17
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants