Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RSpec annotations. #8654

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Improve RSpec annotations. #8654

merged 1 commit into from
Sep 9, 2020
+35 −14

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 8, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add reason for pending specs and improve escaping function.

Sorry, something went wrong.

@reitermarkus reitermarkus force-pushed the rspec-github-actions branch 3 times, most recently from 37273a7 to c0796e3 Compare September 8, 2020 19:10
@jonchang
Copy link
Contributor

jonchang commented Sep 9, 2020

This is really cool!

MikeMcQuaid
MikeMcQuaid reviewed Sep 9, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏🏻

@reitermarkus reitermarkus marked this pull request as ready for review September 9, 2020 16:52
@reitermarkus reitermarkus merged commit 456e674 into Homebrew:master Sep 9, 2020
@reitermarkus reitermarkus deleted the rspec-github-actions branch September 9, 2020 19:54
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reitermarkus @jonchang @MikeMcQuaid @BrewTestBot