Skip to content

cask/audit: detect tag from URL #8662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Sep 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The current method of using cask.version as a tag is not good enough as many repositories add a prefix such as v to their tags.

This PR adds two new methods to SharedAudits: github_tag_from_url and gitlab_tag_from_url, which can be used by brew cask audit to detect a version tag from GitHub/GitLab URLs.

Admittedly, GitLab uploads don't seem to include the tag in their URLs, but this is not a major problem as only two casks are downloaded from GitLab. (See https://github.com/Homebrew/homebrew-cask/search?q=%22gitlab.com%22) Perhaps as a workaround we could hardcode the tags for these two casks?

Related: Homebrew/homebrew-cask/pull/88936

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
dawidd6 Dawid Dziurla
@reitermarkus reitermarkus merged commit 27dcba9 into Homebrew:master Sep 9, 2020
@reitermarkus
Copy link
Member

Thanks, @SeekingMeaning!

@SeekingMeaning SeekingMeaning deleted the audit/cask-prerelease branch September 9, 2020 17:32
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants