cask/audit: detect tag from URL #8662
Merged
+26
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?The current method of using
cask.version
as a tag is not good enough as many repositories add a prefix such asv
to their tags.This PR adds two new methods to
SharedAudits
:github_tag_from_url
andgitlab_tag_from_url
, which can be used bybrew cask audit
to detect a version tag from GitHub/GitLab URLs.Admittedly, GitLab uploads don't seem to include the tag in their URLs, but this is not a major problem as only two casks are downloaded from GitLab. (See https://github.com/Homebrew/homebrew-cask/search?q=%22gitlab.com%22) Perhaps as a workaround we could hardcode the tags for these two casks?
Related: Homebrew/homebrew-cask/pull/88936