Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew.sh: use HOMEBREW_GIT to detect HOMEBREW_VERSION #8663

Merged
merged 2 commits into from
Sep 10, 2020
Merged

brew.sh: use HOMEBREW_GIT to detect HOMEBREW_VERSION #8663

merged 2 commits into from
Sep 10, 2020
+8 −8

Conversation

maxim-belkin
Copy link
Contributor

@maxim-belkin maxim-belkin commented Sep 9, 2020 •
edited
Loading

Move things a tiny bit so that we can use HOMEBREW_GIT (instead of git) to detect HOMEBREW_VERSION.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sorry, something went wrong.

claui
claui approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@claui claui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. LGTM

MikeMcQuaid
MikeMcQuaid approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me! One suggestion given we're bumping anyway.

@maxim-belkin @MikeMcQuaid
brew.sh: update implied HOMEBREW_VERSION
b1cc9bd 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@maxim-belkin
Copy link
Contributor Author

Thanks to both of you!

@MikeMcQuaid MikeMcQuaid merged commit cfa03c8 into Homebrew:master Sep 10, 2020
@MikeMcQuaid
Copy link
Member

Thanks @maxim-belkin!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
@maxim-belkin maxim-belkin deleted the use-homebrew-git-variable branch February 27, 2023 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid

@claui claui

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxim-belkin @MikeMcQuaid @claui @BrewTestBot