dev-cmd/typecheck: Update the Sorbet TODO file in --update-definitions
#8664
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [Sorbet's TODO file](https://sorbet.org/docs/rbi#the-todo-rbi-file) is useful to be periodically regenerated when we're trying to deal with typing errors. The result is an updated `sorbet/rbi/todo.rbi` file that defines missing constants. During GSoC, we [did update this file on occasional Tapioca updates](https://github.com/Homebrew/brew/blame/master/Library/Homebrew/sorbet/rbi/todo.rbi), according to the history. That suggests to me that it should be part of this command.
issyl0
force-pushed
the
typecheck-update-todo-file
branch
from
ecef35a to
42a4e86
Compare
|
For some stats, regenerating this file takes us from 40 errors (some of which are about the |
|
Looks good to me. Thank you @issyl0! 👏🏽 |
vidusheeamoli
approved these changes
Sep 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you written new tests for your changes? Here's an example.brew stylewith your changes locally?brew testswith your changes locally?sorbet/rbi/todo.rbifile that defines missing constants. During GSoC, we did update this file on occasional Tapioca updates, according to the history. That suggests to me that it should be part of this command.