Skip to content

Output annotations for brew cask audit (again). #8671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This was previously done in the homebrew/cask CI workflow.

Sorry, something went wrong.

@reitermarkus reitermarkus merged commit d8905d5 into Homebrew:master Sep 10, 2020
@reitermarkus reitermarkus deleted the audit-annotations branch September 10, 2020 00:01
@MikeMcQuaid
Copy link
Member

Could/is this done for brew audit and/or brew style too?

@reitermarkus
Copy link
Member Author

It should already work for brew style.

@MikeMcQuaid
Copy link
Member

@reitermarkus Would you be able to write up an issue describing what someone would need to do for this to work with brew audit?

@reitermarkus
Copy link
Member Author

Would you be able to write up an issue describing what someone would need to do for this to work with brew audit?

Too late. 😉

#8684

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants