Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck: skip formula even if quiet #8676

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It was discovered in Homebrew/homebrew-core/pull/60897 that running brew livecheck --quiet overrides any skips for e.g. versioned formulae. This PR moves a few return statements to always execute regardless of whether or not --quiet is passed as an argument.

Sorry, something went wrong.

Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SeekingMeaning, the changes seem right to me.

@MikeMcQuaid MikeMcQuaid merged commit 3f26b4a into Homebrew:master Sep 10, 2020
@MikeMcQuaid
Copy link
Member

Thanks @SeekingMeaning!

@SeekingMeaning SeekingMeaning deleted the livecheck/skip-quietly branch September 10, 2020 07:39
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants