Skip to content

Don't override global system_command methods in download strategies. #8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Otherwise curl would call these inside of download strategies where print_stderr was set to false for system_commands.

Fixes #8682.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
dywedir Vlad M.
@MikeMcQuaid MikeMcQuaid merged commit bd9c241 into Homebrew:master Sep 11, 2020
@MikeMcQuaid
Copy link
Member

Thanks @reitermarkus!

@reitermarkus reitermarkus deleted the curl-progress branch September 11, 2020 10:12
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since brew 2.5.0, download progress is not shown
3 participants