Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-cask-pr: add support for :latest #8688

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a follow-up PR to #7986

Allows for updating a cask from an old version to :latest, or from :latest to a new version

Related: Homebrew/homebrew-cask#89077

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mkmik Marko Mikulicic
@SeekingMeaning SeekingMeaning added the cask Homebrew Cask label Sep 11, 2020
@SeekingMeaning SeekingMeaning merged commit bd90d66 into Homebrew:master Sep 12, 2020
@SeekingMeaning SeekingMeaning deleted the bump-cask-pr/latest branch September 12, 2020 00:44
@core-code
Copy link
Contributor

not sure if its interesting just wanted to mention i got this in BigSur

Error: cannot load such file -- ruby-progressbar
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/rubocop-0.90.0/lib/rubocop/formatter/fuubar_style_formatter.rb:3:in `<top (required)>'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/rubocop-0.90.0/lib/rubocop.rb:590:in `require_relative'
/usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/rubocop-0.90.0/lib/rubocop.rb:590:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/usr/local/Homebrew/Library/Homebrew/style.rb:76:in `run_rubocop'
/usr/local/Homebrew/Library/Homebrew/style.rb:52:in `check_style_impl'
/usr/local/Homebrew/Library/Homebrew/style.rb:15:in `check_style_and_print'
/usr/local/Homebrew/Library/Homebrew/cask/cmd/style.rb:24:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/cmd/abstract_command.rb:89:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/cmd.rb:237:in `run'
/usr/local/Homebrew/Library/Homebrew/cask/cmd.rb:165:in `run'
/usr/local/Homebrew/Library/Homebrew/cmd/cask.rb:14:in `cask'
/usr/local/Homebrew/Library/Homebrew/brew.rb:119:in `<main>'
Error: `brew cask style --fix` failed!

@SeekingMeaning
Copy link
Contributor Author

Doesn't seem to related to this pull request (Could you open an issue for this?)

@issyl0
Copy link
Member

issyl0 commented Sep 18, 2020

Big Sur beta is officially unsupported, so diagnosing and fixing the issue in a PR is the way to go please @core-code.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants