Skip to content

sorbet: Regenerate RBI file for the spoom gem #8706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2020
Merged

sorbet: Regenerate RBI file for the spoom gem #8706

merged 1 commit into from
Sep 12, 2020
+4 −4

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 12, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Sorbet was reporting parameter ordering errors in a previous version of this RBI file due to a bug in Tapioca.
  • Rather than wait for a new version of the spoom gem for brew typecheck --update-definitions to work on, I manually deleted the RBI file and used that command to generate an updated one with the latest Tapioca version (0.4.5) which fixes the ordering bug.
  • Before, brew typecheck surfaced 36 errors. Now, it surfaces 24. Much more pleasant.

Sorry, something went wrong.

@issyl0
sorbet: Regenerate RBI file for the spoom gem
06b4b4d 
- Sorbet was reporting parameter ordering errors in a previous version
  of this RBI file due to [a bug in Tapioca](Shopify/tapioca#116).
- Rather than wait for a new version of the `spoom` gem for
  `brew typecheck --update-definitions` to work on, I manually deleted the
  RBI file and used that command to generate an updated one with the
  latest Tapioca version (0.4.5) which fixes the ordering bug.
- Before, `brew typecheck` surfaced 36 errors. Now, it surfaces 24. Much more pleasant.
@issyl0 issyl0 merged commit b9982f1 into Homebrew:master Sep 12, 2020
@issyl0 issyl0 deleted the regenerate-rbi-file-for-spoom branch September 12, 2020 16:21
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@issyl0 @BrewTestBot