Skip to content

Strip escape codes from annotations. #8717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 13, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Otherwise you end up with annotations like this:

download not possible: Checksum for Cask 'rescuetime' does not match.
Expected: �[32me4a150a0e9278a32c787475c7549b5af47634b0061146e69552bc02a6396a2bf�[0m
  Actual: �[31m41f0f340ec75b8296756e4129f6df8743279ddfd77f581d825839c7d7725088f�[0m
    File: /Users/runner/Library/Caches/Homebrew/downloads/6c16425385932119cb691c50100bf4fe56fbd2c9979a4db3433801a155ebf112--RescueTimeInstaller.pkg
To retry an incomplete download, remove the file above.
If the issue persists, visit:
  �[4mhttps://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/reporting_bugs/checksum_does_not_match_error.md�[24m

Sorry, something went wrong.

@claui claui added the usability Usability of Homebrew/brew label Sep 13, 2020
@reitermarkus reitermarkus merged commit a613918 into Homebrew:master Sep 13, 2020
@reitermarkus reitermarkus deleted the ansi-annotations branch September 13, 2020 22:23
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age usability Usability of Homebrew/brew
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants