Skip to content

Refactor cask audit warnings. #8719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Previously cask audit would fail on both warnings and errors. This makes it so it only fails on errors. For this, some warnings are now hard errors (no casks should be failing these anyways).

This allows showing a warning for existing casks and hard errors for new casks, e.g. for the desc stanza. This way contributors will hopefully notice that we want a description to be added while not making CI fail for simple version bumps.

Sorry, something went wrong.

@reitermarkus reitermarkus added the cask Homebrew Cask label Sep 14, 2020
@reitermarkus reitermarkus requested a review from a team September 14, 2020 02:24
Copy link
Contributor

@claui claui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reitermarkus reitermarkus requested review from claui and a team September 14, 2020 11:13
@reitermarkus reitermarkus merged commit 7589a35 into Homebrew:master Sep 14, 2020
@reitermarkus reitermarkus deleted the cask-audit-errors branch September 14, 2020 11:43
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 12, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants