Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr-pull: don't require bintray credentials to be set #8727

Merged
merged 1 commit into from
Sep 15, 2020
Merged

pr-pull: don't require bintray credentials to be set #8727

merged 1 commit into from
Sep 15, 2020
+4 −12

Conversation

dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented Sep 15, 2020

It blocks uploading to GitHub Releases where Bintray credentials are not needed.
Also those checks are already performed in bintray.rb.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sorry, something went wrong.

@dawidd6
pr-pull: don't require bintray credentials to be set
0bf491b 
It blocks uploading to GitHub Releases where Bintray credentials are not needed.
Also those checks are already performed in `bintray.rb`.
dawidd6
dawidd6 commented Sep 15, 2020
View reviewed changes
Library/Homebrew/dev-cmd/pr-pull.rb
@@ -4,7 +4,6 @@
require "cli/parser"
require "utils/github"
require "tmpdir"
require "bintray"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require does not seem to be needed anymore.

@dawidd6
Copy link
Contributor Author

dawidd6 commented Sep 15, 2020

Need to wait for: Homebrew/homebrew-test-bot#500

@dawidd6 dawidd6 merged commit 1700214 into Homebrew:master Sep 15, 2020
@dawidd6 dawidd6 deleted the pr-pull-gh-rel branch September 15, 2020 13:40
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidd6 @MikeMcQuaid @BrewTestBot