Skip to content

Set Accept-Language header for all curl requests. #8730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 15, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Homebrew/homebrew-cask#89251 is currently failing because curl without the Accept-Language header is returning a 404 for https://www.minecraft.net/.

I don't think it hurts passing this header to all requests (tried brew fetch with a bunch of formulae and casks).

curl -LI https://www.minecraft.net/ # 404
curl -LI -H 'Accept-Language: en' https://www.minecraft.net/ # 200

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
issyl0 Issy Long
@reitermarkus reitermarkus merged commit 3acb2e2 into Homebrew:master Sep 15, 2020
@reitermarkus reitermarkus deleted the curl-language branch September 15, 2020 18:01
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants