bump-cask-pr: fix branch name for versions with colon #8731
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeekingMeaning
force-pushed
the
bump-cask-pr/version-with-colon
branch
from
ab9c62b to
cb4d423
Compare
MikeMcQuaid
approved these changes
Sep 15, 2020
| @@ -193,7 +193,7 @@ def bump_cask_pr | |||
| sourcefile_path: cask.sourcefile_path, | |||
| old_contents: old_contents, | |||
| origin_branch: origin_branch, | |||
| branch_name: "bump-#{cask.token}-#{new_version}", | |||
| branch_name: "bump-#{cask.token}-#{new_version.tr(":", ",")}", | |||
There was a problem hiding this comment.
Suggested change
| branch_name: "bump-#{cask.token}-#{new_version.tr(":", ",")}", | |
| branch_name: "bump-#{cask.token}-#{new_version.tr(":", "-")}", |
Replace commas and colons with hyphens
SeekingMeaning
force-pushed
the
bump-cask-pr/version-with-colon
branch
from
cb4d423 to
584c839
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Sometimes cask versions include a comma and a colon. However, colons are not allowed in Git branch names, so this PR adds a fix for
brew bump-cask-prby replacing the colon with another comma. (Originally, I used a semicolon but this doesn't work well with the Terminal shell as it sees it as the end of a command if it's not placed in quotes)