dev-cmd/pr-pull: refactor and add tests #8754

jonchang · 2020-09-17T09:03:32Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

Continuation of #8724

jonchang · 2020-09-20T04:06:18Z

Ok, this is ready for review. I've structured this pull request so each commit can be looked at in isolation, if desired.

jonchang · 2020-09-21T08:58:58Z

Thanks for the 👀

jonchang changed the title ~~dev-cmd/pr-pull: move functions into utils/~~ dev-cmd/pr-pull: move functions into utils Sep 19, 2020

jonchang added 9 commits September 20, 2020 13:21

dev-cmd/pr-pull: use GitHub API to get PR commits

415c360

dev-cmd/pr-pull: don't assume a master branch

04687ae

utils/git: new file_at_commit function

d09ebf4

utils/git: cherry-pick test

146664b

dev-cmd/pr-pull: tests for bump subject

d116087

utils/git: helper function to get commit msg

cdfb1ba

dev-cmd/pr-pull: use commit message helper

0bb2c96

dev-cmd/pr-pull: refactor and test signoff!

99a5aa0

dev-cmd/pr-pull: refactor and test autosquash!

4b4510d

jonchang changed the title ~~dev-cmd/pr-pull: move functions into utils~~ dev-cmd/pr-pull: refactor and add tests Sep 20, 2020

jonchang requested a review from a team September 20, 2020 04:05

jonchang marked this pull request as ready for review September 20, 2020 04:05

MikeMcQuaid approved these changes Sep 21, 2020

View reviewed changes

jonchang merged commit e082da4 into Homebrew:master Sep 21, 2020

jonchang deleted the refactor-git-cmds branch September 21, 2020 08:59

BrewTestBot added the outdated label Dec 3, 2020

Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020

Provide feedback