Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PULL_REQUEST_TEMPLATE: Add a checklist item for brew man #8767

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 18, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • I've been changing command flags recently. I always forget to run brew man, then I feel bad about causing red CI on my PRs. This has happened to others too, so make brew man more obvious as a thing that one should check.

Sorry, something went wrong.

Partially verified

This commit is signed with the committer’s verified signature.
nandahkrishna’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
- I've been changing command flags recently. I always forget to run
  `brew man`, then I feel bad about causing red CI on my PRs. This has
  happened to others too, so make `brew man` more obvious as a thing
  that one should check.
@issyl0 issyl0 requested a review from a team September 18, 2020 15:26
Copy link
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me!

@claui
Copy link
Contributor

claui commented Sep 18, 2020

No strong opinion about that extra item but definitely 👍 if it makes you feel better @issyl0.

Regardless: let’s aim to create an environment where no one has to feel bad about red tests, ever.

You’re an amazing person and your contributions are 💯, no matter the colour it took for them to be shipped!

@dawidd6 dawidd6 merged commit 227da3a into Homebrew:master Sep 18, 2020
@issyl0 issyl0 deleted the update-pr-template-brew-man branch September 18, 2020 17:35
@MikeMcQuaid
Copy link
Member

Thanks for the PR, agreed. I'm almost wondering whether stuff like this could be autorun and either committed to your PR or committed to a new PR/master and our release tooling checks that it's not outdated 🤔

@vitorgalvao
Copy link
Contributor

I'm almost wondering whether stuff like this could be autorun and either committed to your PR or committed to a new PR/master and our release tooling checks that it's not outdated

On homebrew-cask-fonts we have a GitHub action that runs weekly and submits a PR.

So we could have a daily action that runs brew man and commits or sends a PR if there were any changes. Or have the action run after every PR merge. Either way, I’m confident it’s doable.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants