Skip to content

Fix some typechecking errors. #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2020
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 19, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Also, the StringScanner error will be fixed by sorbet/sorbet#3438.

Sorry, something went wrong.

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the help, Markus! This makes me feel less overwhelmed! It's good to see the number of errors go down significantly having fixed things!

@issyl0 issyl0 merged commit cb02747 into Homebrew:master Sep 19, 2020
@vidusheeamoli
Copy link
Contributor

We're down to 9 errors and I don't think we've ever been this low. Thank you @reitermarkus! 👏

@reitermarkus reitermarkus deleted the sorbet-fixes branch September 19, 2020 16:18
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants