Skip to content

unpack_strategy/dmg: remove deprecated IDME attach flag #8778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020
Merged

unpack_strategy/dmg: remove deprecated IDME attach flag #8778

merged 1 commit into from
Sep 21, 2020

Conversation

miccal
Copy link
Contributor

@miccal miccal commented Sep 19, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

On Catalina the IDME attach flag has been removed -- according to man hdiutil:

Removed the deprecated "hdiutil internet-enable" command and the IDME attach flags.

and when installing a Cask that used a .dmg the following message is printed:

hdiutil: attach: WARNING: ignoring IDME options (obsolete)

Thank you.

Sorry, something went wrong.

@miccal
Copy link
Contributor Author

miccal commented Sep 20, 2020

Thank you @reitermarkus.

@miccal miccal merged commit 431b9c0 into Homebrew:master Sep 21, 2020
@miccal miccal deleted the unpack-strategy-dmg branch September 21, 2020 00:05
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants