Allow installing casks with brew install.
#8808
Conversation
reitermarkus
force-pushed
the
cask-install
branch
6 times, most recently
from
f535895 to
c214212
Compare
|
Fantastic work here @reitermarkus, thank you. |
reitermarkus
force-pushed
the
cask-install
branch
from
c214212 to
7570eaa
Compare
reitermarkus
force-pushed
the
cask-install
branch
from
7570eaa to
08be729
Compare
| def to_objects(only: nil) | ||
| @to_objects ||= {} | ||
| @to_objects[only] ||= downcased_unique_named.flat_map do |name| | ||
| next Tap.fetch(name) if only == :tap || (only.nil? && name.count("/") == 1 && !name.start_with?("./", "/")) |
There was a problem hiding this comment.
Could this get split into a few conditionals or variables? It's a bit hard to follow as a post-if.
| conflicts "--build-from-source", "--build-bottle", "--force-bottle" | ||
|
|
||
| formula_only_options.each do |options| |
There was a problem hiding this comment.
Could this be inlined in this function as formula_only_options isn't used elsewhere and it'd allow you to read through the list of options in order (as before)?
There was a problem hiding this comment.
I had this before but RuboCop complained that the block is too long and I didn't want to fight it.
There was a problem hiding this comment.
@reitermarkus Bah. I feel like ideally these usage blocks would be excluded automatically and, if not, we could exclude cmd and dev-cmd entirely
| * `--appdir`: | ||
| Target location for Applications. Default: `/Applications` | ||
| * `--colorpickerdir`: | ||
| Target location for Color Pickers. Default: `~/Library/ColorPickers` | ||
| * `--prefpanedir`: | ||
| Target location for Preference Panes. Default: `~/Library/PreferencePanes` | ||
| * `--qlplugindir`: | ||
| Target location for QuickLook Plugins. Default: `~/Library/QuickLook` | ||
| * `--mdimporterdir`: | ||
| Target location for Spotlight Plugins. Default: `~/Library/Spotlight` | ||
| * `--dictionarydir`: | ||
| Target location for Dictionaries. Default: `~/Library/Dictionaries` | ||
| * `--fontdir`: | ||
| Target location for Fonts. Default: `~/Library/Fonts` | ||
| * `--servicedir`: | ||
| Target location for Services. Default: `~/Library/Services` | ||
| * `--input_methoddir`: | ||
| Target location for Input Methods. Default: `~/Library/Input Methods` | ||
| * `--internet_plugindir`: | ||
| Target location for Internet Plugins. Default: `~/Library/Internet Plug-Ins` | ||
| * `--audio_unit_plugindir`: | ||
| Target location for Audio Unit Plugins. Default: `~/Library/Audio/Plug-Ins/Components` | ||
| * `--vst_plugindir`: | ||
| Target location for VST Plugins. Default: `~/Library/Audio/Plug-Ins/VST` | ||
| * `--vst3_plugindir`: | ||
| Target location for VST3 Plugins. Default: `~/Library/Audio/Plug-Ins/VST3` | ||
| * `--screen_saverdir`: |
There was a problem hiding this comment.
This really bloats the brew install options for options that feel like they are both infrequently used and better handled with environment variables.
brew stylewith your changes locally?brew testswith your changes locally?brew manlocally and committed any changes?