Skip to content

Refactor global Cask::Config. #8822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Sep 29, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Needed so we can pass cask options more easily from non-cask commands.

Sorry, something went wrong.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@reitermarkus reitermarkus merged commit fc6ef72 into Homebrew:master Oct 1, 2020
@reitermarkus reitermarkus deleted the cask-config branch October 1, 2020 01:29
@@ -30,14 +30,16 @@ def initialize(content)
@content = content.force_encoding("UTF-8")
end

def load
def load(config:)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has broken the formulae.brew.sh generation: https://github.com/Homebrew/formulae.brew.sh/blob/9afbae0ea8e80749568d6415a0a320a0c840b0a4/script/generate-cask.rb#L15

Could you submit a PR to fix @reitermarkus? Thanks!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants