Skip to content

audit: remove legit version exception #8860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

cc @MikeMcQuaid

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dtrodrigues dtrodrigues force-pushed the remove-legit-version-exception branch from aafdc37 to 9f9ec0d Compare October 5, 2020 14:04
@dtrodrigues dtrodrigues changed the title audi: remove legit version exception audit: remove legit version exception Oct 5, 2020
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@dtrodrigues
Copy link
Member Author

The change to legit was merged prior to re-running CI here, so I'm not sure why it's not being picked up.

Error: 1 problem in 1 formula detected
legit:
  * Stable: version 1.2.0.post0 is redundant with version scanned from URL
Error: Stable: version 1.2.0.post0 is redundant with version scanned from URL
Error: Process completed with exit code 1.

@MikeMcQuaid
Copy link
Member

@dtrodrigues There's sometimes a slight lag; may be worth retrying now.

@dtrodrigues
Copy link
Member Author

Hmm, still didn't work. I'll try again later today.

@reitermarkus
Copy link
Member

It's merged in homebrew-core but not yet in linuxbrew-core.

@dtrodrigues dtrodrigues merged commit 95ba86d into Homebrew:master Oct 5, 2020
@dtrodrigues dtrodrigues deleted the remove-legit-version-exception branch October 5, 2020 23:23
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants