Skip to content

sorbet: Start typechecking install.rb and reinstall.rb #8871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Oct 6, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

  • You can probably tell from the branch name that I had greater ambitions for tonight's Sorbet session than just two files. But I'm tired and it's still two files done!
  • This moves install.rb and reinstall.rb to true.

Sorry, something went wrong.

@issyl0 issyl0 merged commit 569ce08 into Homebrew:master Oct 6, 2020
@issyl0 issyl0 deleted the sorbet-more-typechecked-files branch October 6, 2020 21:15
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants