Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/cmd/info.rb: Fix crash when running brew cask info --github #8881

Merged

Conversation

whoiswillma
Copy link
Contributor

@whoiswillma whoiswillma commented Oct 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Fix crash when using brew cask info --github sl caused by formulae being passed to Cask::Cmd::Info.github_info

Error: undefined method `sourcefile_path' for #<Formulary::FormulaNamespacee3b11e986e0540a2aeccc9b89fd2c30f::Sl:0x00007f9d0d193528>

Sorry, something went wrong.

@whoiswillma whoiswillma marked this pull request as ready for review October 9, 2020 01:43
@whoiswillma whoiswillma force-pushed the william/fix-cask-info-github-error branch from 5c74dbe to 24260e7 Compare October 9, 2020 01:47
@MikeMcQuaid MikeMcQuaid merged commit d8e11cd into Homebrew:master Oct 9, 2020
@MikeMcQuaid
Copy link
Member

Nice catch @whoiswillma!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants