Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix brew edit #8889

Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix brew edit #8889

merged 1 commit into from
Oct 20, 2020

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Oct 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Closes #8876

Sorry, something went wrong.

@MikeMcQuaid
Copy link
Member

This feels like it should also have the brew create messaging you mentioned before.

@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku, you rock!

@MikeMcQuaid MikeMcQuaid merged commit 4b361c2 into Homebrew:master Oct 20, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
@hyuraku hyuraku deleted the fix_brew_edit branch January 27, 2021 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"brew edit" open non-existent formula file
4 participants