Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/info: Add support for casks in brew info #8893

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

whoiswillma
Copy link
Contributor

@whoiswillma whoiswillma commented Oct 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Allow references to casks in brew info, e.g. brew info firefox sl.

  • Add support for --json for casks

Using brew outdated as prior art: #7927

I added --json=v2 which outputs a json dictionary with keys for formulae and casks.

  • Deprecate brew cask info (any more functionality to move over besides --json?)

Sorry, something went wrong.

@whoiswillma whoiswillma marked this pull request as ready for review October 10, 2020 01:51
@whoiswillma whoiswillma force-pushed the william/integrate-brew-info branch from 5ec53db to 957e27d Compare October 10, 2020 20:46
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, nice work!

@whoiswillma whoiswillma force-pushed the william/integrate-brew-info branch from 957e27d to a463348 Compare October 12, 2020 13:22
@MikeMcQuaid
Copy link
Member

Makes sense to me, thanks @whoiswillma!

@MikeMcQuaid MikeMcQuaid merged commit 60046ac into Homebrew:master Oct 26, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants